Merge 2.6.1 to main#75
Merged
Merged
Conversation
…hcheck Interval, Updated Service Account Token Lifecycle (#70) * feat: Add volume and volume mount for service token * chore: fix sources and add changelog Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * feat(enrollment): make certificateAuthorityLogicalName be optional when using enrollment patterns Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * updated error messaging on csr enrollment Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * Update generated docs * chore: update docs + add e2e test for optional CA Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * Update generated docs * feat(healthcheck): bump default healthcheck interval from 1m to 10m Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * chore(deps): bump go version to 1.26 Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * Update generated docs * chore: address copilot feedback. update linter version Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * Update generated docs * chore(ci): bump controller tools version Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * chore(docs): document new Helm chart values for serviceAccount Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> --------- Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> Co-authored-by: Sven Rajala <sven.rajala@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
#74) * command-cert-manager-issuer 2.6.0: Optional CA, Updated Default Healthcheck Interval, Updated Service Account Token Lifecycle (#70) (#71) * feat: Add volume and volume mount for service token * chore: fix sources and add changelog * feat(enrollment): make certificateAuthorityLogicalName be optional when using enrollment patterns * updated error messaging on csr enrollment * Update generated docs * chore: update docs + add e2e test for optional CA * Update generated docs * feat(healthcheck): bump default healthcheck interval from 1m to 10m * chore(deps): bump go version to 1.26 * Update generated docs * chore: address copilot feedback. update linter version * Update generated docs * chore(ci): bump controller tools version * chore(docs): document new Helm chart values for serviceAccount --------- Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> Co-authored-by: Matthew H. Irby <irby@users.noreply.github.com> Co-authored-by: Sven Rajala <sven.rajala@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * Add priorityClassName * remove quote * Update README * chore(AB#89226): add docs on how to contribute to the project Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * chore: update CHANGELOG Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com> Co-authored-by: Morgan Gangwere <470584+indrora@users.noreply.github.com> Co-authored-by: Sven Rajala <sven.rajala@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> Co-authored-by: slammajamma28 <slammajamma28@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Automated merge of release-2.6 changes into main, updating issuer enrollment behavior (CA optional with enrollment patterns), default healthcheck timing, Helm chart security defaults, and associated docs/tests/tooling.
Changes:
- Make
certificateAuthorityLogicalNameoptional when using an enrollment pattern; improve enrollment failure hints and expand test coverage (unit + e2e). - Change the default healthcheck interval from 1 minute to 10 minutes across code, CRDs, and docs.
- Harden Helm chart defaults by disabling SA token automount and using a rotated projected token; add
priorityClassNamesupport.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documentation updates for API links, healthchecks, and installation instructions. |
| docsource/content.md | Mirrored documentation updates for generated docs site/content. |
| CHANGELOG.md | Adds v2.6.0/v2.6.1 release notes including upgrade/security notes. |
| internal/command/command.go | Allows CA omission with enrollment patterns; refactors enrollment error hints. |
| internal/command/command_test.go | Updates validation tests and adds error-message coverage for Sign failures. |
| e2e/run_tests.sh | Adds an e2e case verifying CA is optional with enrollment patterns. |
| api/v1alpha1/issuer_types.go | Updates API comments/optionality and healthcheck default interval documentation. |
| cmd/main.go | Changes the default CLI --default-health-check-interval from 60s to 10m. |
| internal/controller/issuer_controller_test.go | Updates reconcile requeue expectations to the new default interval. |
| deploy/charts/command-cert-manager-issuer/values.yaml | Adds SA token automount/projected-token options and priorityClassName. |
| deploy/charts/command-cert-manager-issuer/templates/serviceaccount.yaml | Sets automountServiceAccountToken from values. |
| deploy/charts/command-cert-manager-issuer/templates/deployment.yaml | Adds projected SA token volume/mount and optional priorityClassName. |
| deploy/charts/command-cert-manager-issuer/templates/crds/issuers.yaml | CRD doc updates for optional CA and 10m healthcheck default. |
| deploy/charts/command-cert-manager-issuer/templates/crds/clusterissuers.yaml | CRD doc updates for optional CA and 10m healthcheck default. |
| deploy/charts/command-cert-manager-issuer/README.md | Documents new chart values and updated healthcheck default wording. |
| config/crd/bases/command-issuer.keyfactor.com_issuers.yaml | Regenerated CRD base with controller-gen v0.17.3 and updated field docs. |
| config/crd/bases/command-issuer.keyfactor.com_clusterissuers.yaml | Regenerated CRD base with controller-gen v0.17.3 and updated field docs. |
| CONTRIBUTING.md | Expanded contribution guidance and updated dev requirements. |
| Makefile | Bumps controller-tools and golangci-lint versions. |
| .github/workflows/test.yml | Updates CI golangci-lint action version to v2.12.2. |
| .golangci.yml | Excludes some linters for _test.go paths. |
| go.mod | Updates the Go toolchain directive version. |
| Dockerfile | Updates builder image to Go 1.26. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release-2.6 to main - Automated PR